Skip to content

chore(analytics-data-regulation-controller): replace Sinon with Jest timers#7970

Merged
cryptodev-2s merged 1 commit intomainfrom
chore/analytics-data-regulation-controller-replace-sinon-with-jest
Feb 18, 2026
Merged

chore(analytics-data-regulation-controller): replace Sinon with Jest timers#7970
cryptodev-2s merged 1 commit intomainfrom
chore/analytics-data-regulation-controller-replace-sinon-with-jest

Conversation

@cryptodev-2s
Copy link
Contributor

@cryptodev-2s cryptodev-2s commented Feb 18, 2026

Explanation

References

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed
  • I've introduced breaking changes in this PR and have prepared draft pull requests for clients and consumer packages to resolve them

Note

Low Risk
Test-only changes plus removal of a dev dependency; risk is limited to potential timer-mocking differences causing flaky/changed test behavior.

Overview
Replaces Sinon-based fake timers in AnalyticsDataRegulationService.test.ts with Jest timers, updating retry/degraded/circuit-breaker tests to advance timers via jest.advanceTimersToNextTimerAsync / jest.advanceTimersByTime and managing lifecycle with jest.useFakeTimers/jest.useRealTimers.

Drops sinon from analytics-data-regulation-controller dev dependencies (and lockfile), reducing the test-only dependency surface without changing production code.

Written by Cursor Bugbot for commit 637fff0. This will update automatically on new commits. Configure here.

@cryptodev-2s cryptodev-2s force-pushed the chore/analytics-data-regulation-controller-replace-sinon-with-jest branch from bf93077 to 637fff0 Compare February 18, 2026 12:23
@cryptodev-2s cryptodev-2s marked this pull request as ready for review February 18, 2026 12:27
@cryptodev-2s cryptodev-2s requested review from a team as code owners February 18, 2026 12:27
@cryptodev-2s cryptodev-2s changed the title chore(analytics-data-regulation-controller): replace Sinon with Jest … chore(analytics-data-regulation-controller): replace Sinon with Jest timers Feb 18, 2026
@cryptodev-2s cryptodev-2s changed the title chore(analytics-data-regulation-controller): replace Sinon with Jest timers chore(analytics-data-regulation-controller): replace Sinon with Jest timers Feb 18, 2026
@cryptodev-2s cryptodev-2s added this pull request to the merge queue Feb 18, 2026
Merged via the queue into main with commit 8a575e8 Feb 18, 2026
306 checks passed
@cryptodev-2s cryptodev-2s deleted the chore/analytics-data-regulation-controller-replace-sinon-with-jest branch February 18, 2026 14:29
khanti42 pushed a commit that referenced this pull request Feb 20, 2026
…st` timers (#7970)

## Explanation

<!--
Thanks for your contribution! Take a moment to answer these questions so
that reviewers have the information they need to properly understand
your changes:

* What is the current state of things and why does it need to change?
* What is the solution your changes offer and how does it work?
* Are there any changes whose purpose might not obvious to those
unfamiliar with the domain?
* If your primary goal was to update one package but you found you had
to update another one along the way, why did you do so?
* If you had to upgrade a dependency, why did you do so?
-->

## References

<!--
Are there any issues that this pull request is tied to?
Are there other links that reviewers should consult to understand these
changes better?
Are there client or consumer pull requests to adopt any breaking
changes?

For example:

* Fixes #12345
* Related to #67890
-->

## Checklist

- [ ] I've updated the test suite for new or updated code as appropriate
- [ ] I've updated documentation (JSDoc, Markdown, etc.) for new or
updated code as appropriate
- [ ] I've communicated my changes to consumers by [updating changelogs
for packages I've
changed](https://github.com/MetaMask/core/tree/main/docs/processes/updating-changelogs.md)
- [ ] I've introduced [breaking
changes](https://github.com/MetaMask/core/tree/main/docs/processes/breaking-changes.md)
in this PR and have prepared draft pull requests for clients and
consumer packages to resolve them

<!-- CURSOR_SUMMARY -->
---

> [!NOTE]
> **Low Risk**
> Test-only changes plus removal of a dev dependency; risk is limited to
potential timer-mocking differences causing flaky/changed test behavior.
> 
> **Overview**
> Replaces Sinon-based fake timers in
`AnalyticsDataRegulationService.test.ts` with Jest timers, updating
retry/degraded/circuit-breaker tests to advance timers via
`jest.advanceTimersToNextTimerAsync` / `jest.advanceTimersByTime` and
managing lifecycle with `jest.useFakeTimers`/`jest.useRealTimers`.
> 
> Drops `sinon` from `analytics-data-regulation-controller` dev
dependencies (and lockfile), reducing the test-only dependency surface
without changing production code.
> 
> <sup>Written by [Cursor
Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit
637fff0. This will update automatically
on new commits. Configure
[here](https://cursor.com/dashboard?tab=bugbot).</sup>
<!-- /CURSOR_SUMMARY -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments